murblanc commented on a change in pull request #1684: URL: https://github.com/apache/lucene-solr/pull/1684#discussion_r482813142
########## File path: solr/core/src/java/org/apache/solr/cluster/placement/SolrCollection.java ########## @@ -0,0 +1,66 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.solr.cluster.placement; + +import java.util.Map; + +/** + * Represents a Collection in SolrCloud (unrelated to {@link java.util.Collection} that uses the nicer name). + */ +public interface SolrCollection { + /** + * The collection name (value passed to {@link Cluster#getCollection(String)}). + */ + String getName(); + + /** + * <p>The {@link Shard}'s over which the data of this {@link SolrCollection} is distributed. + * + * <p>The map is from {@link Shard#getShardName()} to {@link Shard} instance. + */ + Map<String, Shard> getShards(); Review comment: What use case is served by an iterator that only iterates on shard names and that doesn't "materialize" them into `Shard` instances? If it's for finding a `Shard` whose name matches some pattern, we should devise more efficient ways. I'm not against having such an iterator but need help understanding when it might be useful (assuming we already have an iterator that returns `Shard` instances and a method to fetch a given `Shard` by name). ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
