chatman commented on pull request #1684: URL: https://github.com/apache/lucene-solr/pull/1684#issuecomment-686380223
I broadly agree with those principals, and I'm sure everyone does. > 1. placement plugin writing is easy, Agree, but not at the cost of complicated server side code that resides in solr-core. > 2. implementation for this placement API is efficient, and +1 > 3. plugins do not break when Solr is refactored (plugins might be client private so can’t be refactored when Solr code changes). Mostly agree, but not at the cost of thousands of classes. There are simpler ways, as I think we now are clear on, to achieve the same goal. I would also like you to consider another goal (which, IMHO, is *most important*), which is to keeping the solr-core as lean, clean and the footprint of doing so as minimal as possible. Everything that can be done outside solr-core should be done. Autoscaling is not a first class citizen in a search engine, but replica assignment/placement can arguably be so. > Can we make this assumption? Plugin requests a set of properties from a set of nodes, and this is done efficiently. If so I'll gladly simplify my proposal +1. I'm glad we're all on the same page (at least on the verbosity aspect). Thanks for your work, @murblanc. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
