mocobeta commented on a change in pull request #2064:
URL: https://github.com/apache/lucene-solr/pull/2064#discussion_r519355253
##########
File path:
lucene/test-framework/src/java/org/apache/lucene/util/fst/FSTTester.java
##########
@@ -95,7 +95,7 @@ private static BytesRef toBytesRef(IntsRef ir) {
return br;
}
- static String getRandomString(Random random) {
+ public static String getRandomString(Random random) {
Review comment:
I'd use RandomStrings instead of making the FSTTester method public and
adding extra documentation for it (I prefer only one recommended way to
implement one thing), if we can safely switch them.
I checked the `FSTTester.getRandomString()` method if we can safely replace
it with `RandomStrings.randomUnicodeOfCodepointLength()`. It seems there is a
small, but intentional difference (it generates strings that consists of
characters within the range of codepoint 97('a') to 102('f'), with a 50%
possibility)... not fully sure the details, but it somewhat serves for testing
FST?
https://github.com/apache/lucene-solr/blob/master/lucene/test-framework/src/java/org/apache/lucene/util/fst/FSTTester.java#L98-L122
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
