mocobeta commented on a change in pull request #2064:
URL: https://github.com/apache/lucene-solr/pull/2064#discussion_r519363648
##########
File path:
lucene/test-framework/src/java/org/apache/lucene/util/fst/FSTTester.java
##########
@@ -95,7 +95,7 @@ private static BytesRef toBytesRef(IntsRef ir) {
return br;
}
- static String getRandomString(Random random) {
+ public static String getRandomString(Random random) {
Review comment:
RandomStrings might be okay here but I'm not so confident about
switching to it because of the difference... i aded a note to the method's
javadoc.
https://github.com/apache/lucene-solr/pull/2064/commits/a0d97b595f8d01f81db6d1f068aa8ae11d47887e
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
