sigram commented on a change in pull request #2065:
URL: https://github.com/apache/lucene-solr/pull/2065#discussion_r521322184
##########
File path: solr/core/src/test/org/apache/solr/handler/TestContainerPlugin.java
##########
@@ -366,7 +381,7 @@ public void m2(SolrQueryRequest req, SolrQueryResponse rsp)
{
}
- public static class CConfig extends PluginMeta {
+ public static class CConfig implements ReflectMapWriter {
Review comment:
I don't understand this change. Do all config beans have to implement
`ReflectMapWriter`?
If that's the case, and all config beans have to implement ReflectMapWriter
then that's what the generic type in ConfigurablePlugin<T> should use. If not
then this test is misleading again because it suggests you have to implement
additional interfaces to have a usable config bean.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
