sigram commented on a change in pull request #2065:
URL: https://github.com/apache/lucene-solr/pull/2065#discussion_r521325260



##########
File path: solr/core/src/java/org/apache/solr/api/AnnotatedApi.java
##########
@@ -62,6 +63,8 @@
 
 public class AnnotatedApi extends Api implements PermissionNameProvider , 
Closeable {
   private static final Logger log = 
LoggerFactory.getLogger(MethodHandles.lookup().lookupClass());
+  private static final ObjectMapper mapper = 
SolrJacksonAnnotationInspector.createObjectMapper()

Review comment:
       Oh, I didn't notice before that it was created for each request. That 
was horrible!
   
   Still, we already have one instance here and another (configured the same) 
in `ContainerPluginsRegistry`. We should probably expose this instance here and 
reuse it in `ContainerPluginsRegistry`.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Reply via email to