zacharymorn commented on pull request #2068: URL: https://github.com/apache/lucene-solr/pull/2068#issuecomment-725853994
> All of it looks good, Zach. Sorry about my lack of consistency here but on as second thought I think we should add a safety switch of perhaps force-disabling the native build - just in case we commit it in and have to do it for some reason. > > I'll work on this later today and commit it in. > > I also feel tempted to add tests that utilize this native code. This can come as a separate issue though. I just pushed up a commit that adds tests to exercise the native library loading part. Seems to be working fine on my Mac. Could you please give it a try to see it works on Windows as well? On the other hand, I think these tests will break if run from IDEs. Do we need to support that in this PR? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
