dweiss commented on a change in pull request #2068:
URL: https://github.com/apache/lucene-solr/pull/2068#discussion_r521912140



##########
File path: lucene/misc/native/src/main/posix/NativePosixUtil.cpp
##########
@@ -38,12 +38,12 @@
 
 #ifdef LINUX
 /*
- * Class:     org_apache_lucene_store_NativePosixUtil
+ * Class:     org_apache_lucene_misc_store_NativePosixUtil
  * Method:    posix_fadvise
  * Signature: (Ljava/io/FileDescriptor;JJI)V
  */
 extern "C"
-JNIEXPORT jint JNICALL 
Java_org_apache_lucene_store_NativePosixUtil_posix_1fadvise(JNIEnv *env, jclass 
_ignore, jobject fileDescriptor, jlong offset, jlong len, jint advice)
+JNIEXPORT jint JNICALL 
Java_org_apache_lucene_misc_store_NativePosixUtil_posix_1fadvise(JNIEnv *env, 
jclass _ignore, jobject fileDescriptor, jlong offset, jlong len, jint advice)

Review comment:
       Yeah. We really should try to add a test that tries to run with these 
libs. I don't know how to handle this yet - can be a follow-up issue.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Reply via email to