iverase commented on pull request #2094:
URL: https://github.com/apache/lucene-solr/pull/2094#issuecomment-732187741


   We have the same situation in PackedInts and FST where you cannot just pass 
a wrapped object.  
   There is as well the issue where the serialisation / deserialisation is 
endian dependent. In DocIdsWriter we serialise using:
   
   ```
             out.writeShort(out, (short) (docIds[start + i] >>> 8));
             out.writeByte((byte) docIds[start + i]);
   ```
   
   But deserialise using:
   
   ```
          long l1 = in readLong(in);
         long l2 = in readLong(in);
         long l3 = in readLong(in);
   ```
   
   There is a similar situation in `CompressingStoredFieldsWriter`. 
   
   I have another iteration to see if we can simplify but just wrapping the 
IndexOutput / IndexInput now that I have better understanding on the problem.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Reply via email to