donnerpeter commented on a change in pull request #2202:
URL: https://github.com/apache/lucene-solr/pull/2202#discussion_r558220984
##########
File path:
lucene/analysis/common/src/java/org/apache/lucene/analysis/hunspell/Dictionary.java
##########
@@ -209,6 +178,7 @@ public Dictionary(
this.needsOutputCleaning = false; // set if we have an OCONV
flagLookup.add(new BytesRef()); // no flags -> ord 0
+ Path tempPath = getDefaultTempDir(); // TODO: make this configurable?
Review comment:
BTW any idea why the default temp dir is used here for reading from aff
file twice, but another temp dir is passed to the constructor and used for
similarly-temp-looking task (external dictionary entry sorting)? Can these
tasks use the same dir? And if yes, which one? Clients would be simpler if they
hadn't to care about temp dirs, but maybe there are use cases for passing the
temp dir explicitly.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
