donnerpeter commented on a change in pull request #2202:
URL: https://github.com/apache/lucene-solr/pull/2202#discussion_r558225290



##########
File path: 
lucene/analysis/common/src/java/org/apache/lucene/analysis/hunspell/Stemmer.java
##########
@@ -654,7 +646,7 @@ private boolean checkCondition(
                   true,
                   circumfix,
                   caseVariant));
-        } else if (dictionary.complexPrefixes == false && 
dictionary.twoStageAffix) {
+        } else if (!dictionary.complexPrefixes && dictionary.twoStageAffix) {

Review comment:
       I prefer shorter versions (especially given the short column limit of 
spotlessJava), and IntelliJ highlights this by default, but if you insist, I 
can disable the highlighting and live with it. What's the rule exactly, write 
`x == false` instead of `!x` everywhere?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Reply via email to