[ 
https://issues.apache.org/jira/browse/LUCENE-9956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17344183#comment-17344183
 ] 

Greg Miller commented on LUCENE-9956:
-------------------------------------

Yeah, I think it's worth seeing if {{rewrite}} can be used before moving 
forward with exposing more internals of DDQ. The DDQ functions as a 
{{BooleanQuery}} anyway (because of {{rewrite}}) so it seems like checking the 
"generated" BQ for the purpose of testing DDQ might be a better approach? If 
what you're really trying to do is test the DDQ you've created, it seems like 
testing the BQ that will ultimately get executed in an {{IndexSearcher}} (via. 
{{rewrite}}) might be ideal, but I could be missing something.

If, on the other hand, there's some use-cases for needing separate access to 
the base query and drill downs (much like in {{DrillSideways}}), then making 
these more broadly visible/accessible seems reasonable.

> Make getBaseQuery API from DrillDownQuery public 
> -------------------------------------------------
>
>                 Key: LUCENE-9956
>                 URL: https://issues.apache.org/jira/browse/LUCENE-9956
>             Project: Lucene - Core
>          Issue Type: Improvement
>          Components: modules/facet
>    Affects Versions: main (9.0)
>            Reporter: Gautam Worah
>            Priority: Trivial
>
> It would be great if users could access the baseQuery of a DrillDownQuery. I 
> think this can be useful for folks who want to access/test the clauses of a 
> BooleanQuery (for example) after they've already wrapped it into a 
> DrillDownQuery.
>  
>  Currently the {{Query getBaseQuery()}} method is package private by default.
> If this proposed change does not make sense, or if this change breaks the 
> semantic of the class, I am happy to explore other ways of doing this!
>  
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Reply via email to