[ 
https://issues.apache.org/jira/browse/LUCENE-9956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17344925#comment-17344925
 ] 

Greg Miller commented on LUCENE-9956:
-------------------------------------

Ah, thanks [~gworah]. Sounds like a good use-case for needing to expose the 
base query then. What I'm hearing is that there are optimizations that should 
_only_ apply to the base query, so {{rewriting}} the query isn't helpful here 
since that will produce a {{BooleanQuery}} that contains all of the drill down 
dims applied. Thanks for clarifying!

+1 to adding public access to the base query. I left a comment on your PR with 
regards to the approach of making drill down dims public as well. I like making 
everything public for consistency, but if that work kind of balloons, I don't 
mind tackling just the base query for now. That's my opinion at least.

> Make getBaseQuery API from DrillDownQuery public 
> -------------------------------------------------
>
>                 Key: LUCENE-9956
>                 URL: https://issues.apache.org/jira/browse/LUCENE-9956
>             Project: Lucene - Core
>          Issue Type: Improvement
>          Components: modules/facet
>    Affects Versions: main (9.0)
>            Reporter: Gautam Worah
>            Priority: Trivial
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> It would be great if users could access the baseQuery of a DrillDownQuery. I 
> think this can be useful for folks who want to access/test the clauses of a 
> BooleanQuery (for example) after they've already wrapped it into a 
> DrillDownQuery.
>  
>  Currently the {{Query getBaseQuery()}} method is package private by default.
> If this proposed change does not make sense, or if this change breaks the 
> semantic of the class, I am happy to explore other ways of doing this!
>  
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Reply via email to