gsmiller commented on a change in pull request #240: URL: https://github.com/apache/lucene/pull/240#discussion_r693359352
########## File path: lucene/facet/src/java/org/apache/lucene/facet/DrillSideways.java ########## @@ -520,10 +458,39 @@ private DrillDownQuery getDrillDownQuery( } @SuppressWarnings("unchecked") - private <R> ConcurrentDrillSidewaysResult<R> searchSequentially( - final DrillDownQuery query, final CollectorManager<?, R> hitCollectorManager) + private <C extends Collector, R> ConcurrentDrillSidewaysResult<R> searchSequentially( + final DrillDownQuery query, final CollectorManager<C, R> hitCollectorManager) throws IOException { + // This mirrors a similar hack from DrillSideways#search(query, collector). + // Without this cache, LRU cache will be used, causing acceptDocs to be null during collection Review comment: Also, @zacharymorn, since this appears to be a pre-existing bug that's separate from the change you're working on here, I went ahead and cut an issue for it: [LUCENE-10060](https://issues.apache.org/jira/browse/LUCENE-10060). Let's take our conversation over there so your PR doesn't get too overwhelmed by it :). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org