gsmiller commented on a change in pull request #240:
URL: https://github.com/apache/lucene/pull/240#discussion_r695278754
##########
File path: lucene/facet/src/java/org/apache/lucene/facet/DrillSideways.java
##########
@@ -520,10 +458,39 @@ private DrillDownQuery getDrillDownQuery(
}
@SuppressWarnings("unchecked")
- private <R> ConcurrentDrillSidewaysResult<R> searchSequentially(
- final DrillDownQuery query, final CollectorManager<?, R>
hitCollectorManager)
+ private <C extends Collector, R> ConcurrentDrillSidewaysResult<R>
searchSequentially(
+ final DrillDownQuery query, final CollectorManager<C, R>
hitCollectorManager)
throws IOException {
+ // This mirrors a similar hack from DrillSideways#search(query, collector).
+ // Without this cache, LRU cache will be used, causing acceptDocs to be
null during collection
Review comment:
Ah, I see the problem. Thanks again for the details! I was overlooking
L:521 in `LRUQueryCache` where it always provides a `null` `acceptDocs`. I
think the solution to both this issue and the one I detailed in LUCENE-10060 is
the same (and is the one you've included in this PR).
If I have some time this week, I'll see if I can write a test case that
reliably repro's the issue. If I can, I'll bundle the test and the fix you've
written here into a separate PR against LUCENE-10060 that can just get rebased
into your change (should be an easy conflict to resolve). If you beat me to it
with pushing this PR, I'll just work on the test case and confirm it's fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
