rmuir commented on pull request #567: URL: https://github.com/apache/lucene/pull/567#issuecomment-1000346720
> The code Uwe provided in the patch is fixing a true bug - it's just masked by the tests running in classpath only. In other words: if the tests pass after applying this patch, nothing changes for the classpath mode... and things will improve on the module-system layer side. Sure, I get that. But If i revert his commit or otherwise introduce regression, tests keep passing :) That's my point. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
