rmuir commented on pull request #567: URL: https://github.com/apache/lucene/pull/567#issuecomment-1000482712
Well, it does seem this particular method signature "can't work", unless any code that uses this helper explicitly opens up their module to lucene-core... and that's too confusing. As far as what other stuff is broken by modules, that's my bigger concern: how can we test this? what else is broke? In this example it is literally just a couple words of javadocs that they slid into this method with jdk9 and now we have to deprecate APIs because of it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
