[
https://issues.apache.org/jira/browse/LUCENE-10381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17482125#comment-17482125
]
Greg Miller commented on LUCENE-10381:
--------------------------------------
[~jpountz] your change looks right to me. Apologies for not thinking of this.
It might be nice to default {{facetsConfig}} in {{IndexState}} to a new default
instance if one isn't provided to be safe, but I don't think that's critically
important. I haven't touched {{luceneutil}} yet so maybe I'll use this as a
good opportunity to setup a dev environment for it and propose that change.
Thanks again for jumping in here!
> Require users to provide FacetsConfig with initializing
> DefaultSortedSetDocValuesReaderState
> --------------------------------------------------------------------------------------------
>
> Key: LUCENE-10381
> URL: https://issues.apache.org/jira/browse/LUCENE-10381
> Project: Lucene - Core
> Issue Type: Improvement
> Components: modules/facet
> Reporter: Greg Miller
> Priority: Minor
> Time Spent: 1h
> Remaining Estimate: 0h
>
> In LUCENE-10250, we added the ability for users to provide their
> {{FacetsConfig}} when constructing
> {{{}DefaultSortedSetDocValuesReaderState{}}}. This is necessary for some of
> the new functionality and bug fixes in SSDV faceting (e.g., we need to know
> if a dim is configured as hierarchical, multivalued and/or requiring dim
> counts). To remain backwards-compatible, existing ctors were maintained and
> users don't need to provide config, which means we have to fall back to some
> default (pre-existing) behavior if we don't have the config.
> We should make the config mandatory going forward so that users always
> explicitly provide their config. This is consistent with taxonomy faceting
> where users must provide config. It's also pretty trappy to let users setup
> their state without config as they might just overlook the need to provide it.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
