[ https://issues.apache.org/jira/browse/LUCENE-10381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17482551#comment-17482551 ]
Greg Miller commented on LUCENE-10381: -------------------------------------- [~jpountz] I think there may still be an issue actually with the benchmarks. I'm seeing the following. Looking into this now... Exception in thread "Thread-1" java.lang.RuntimeException: java.lang.RuntimeException: java.lang.IllegalArgumentException: field "$facets" was not indexed with SortedSetDocValues at perf.TaskThreads$TaskThread.run(TaskThreads.java:105) Caused by: java.lang.RuntimeException: java.lang.IllegalArgumentException: field "$facets" was not indexed with SortedSetDocValues at perf.SearchTask.go(SearchTask.java:319) at perf.TaskThreads$TaskThread.run(TaskThreads.java:91) Caused by: java.lang.IllegalArgumentException: field "$facets" was not indexed with SortedSetDocValues at org.apache.lucene.facet.sortedset.DefaultSortedSetDocValuesReaderState.<init>(DefaultSortedSetDocValuesReaderState.java:86) at perf.IndexState.getSortedSetReaderState(IndexState.java:102) at perf.SearchTask.go(SearchTask.java:211) ... 1 more > Require users to provide FacetsConfig with initializing > DefaultSortedSetDocValuesReaderState > -------------------------------------------------------------------------------------------- > > Key: LUCENE-10381 > URL: https://issues.apache.org/jira/browse/LUCENE-10381 > Project: Lucene - Core > Issue Type: Improvement > Components: modules/facet > Reporter: Greg Miller > Priority: Minor > Time Spent: 1h > Remaining Estimate: 0h > > In LUCENE-10250, we added the ability for users to provide their > {{FacetsConfig}} when constructing > {{{}DefaultSortedSetDocValuesReaderState{}}}. This is necessary for some of > the new functionality and bug fixes in SSDV faceting (e.g., we need to know > if a dim is configured as hierarchical, multivalued and/or requiring dim > counts). To remain backwards-compatible, existing ctors were maintained and > users don't need to provide config, which means we have to fall back to some > default (pre-existing) behavior if we don't have the config. > We should make the config mandatory going forward so that users always > explicitly provide their config. This is consistent with taxonomy faceting > where users must provide config. It's also pretty trappy to let users setup > their state without config as they might just overlook the need to provide it. -- This message was sent by Atlassian Jira (v8.20.1#820001) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org