[ 
https://issues.apache.org/jira/browse/LUCENE-10463?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17505174#comment-17505174
 ] 

Tomoko Uchida edited comment on LUCENE-10463 at 3/12/22, 4:29 AM:
------------------------------------------------------------------

Would you share your thoughts on that, [~dweiss]  - does it make sense to add a 
Gradle task that just outputs (to stdout or a temporary file) the target java 
version (`sourceCompatibility` and `targetCompatibility`) to verify the jar 
Manifests in the smoke tester? Or, in a more straightforward way, we could port 
the whole `checkJARMetaData()` method to a Gradle task.

[https://github.com/apache/lucene/blob/main/dev-tools/scripts/smokeTestRelease.py#L127]


was (Author: tomoko uchida):
Would you share your thoughts on that, [~dweiss]  - does it make sense to add a 
Gradle task to just outputs (to stdout or a temporary file) the target java 
version (`sourceCompatibility` and `targetCompatibility`) to verify the jar 
Manifests in the smoke tester? Or, in a more straightforward way, we could port 
the whole `checkJARMetaData()` method to a Gradle task.

[https://github.com/apache/lucene/blob/main/dev-tools/scripts/smokeTestRelease.py#L127]

> Make smoke tester script work on main branch (java 17)
> ------------------------------------------------------
>
>                 Key: LUCENE-10463
>                 URL: https://issues.apache.org/jira/browse/LUCENE-10463
>             Project: Lucene - Core
>          Issue Type: Task
>            Reporter: Tomoko Uchida
>            Priority: Major
>
> The smoke tester script has been obsoleted on main after upgrading to Java 
> 17. To enable nightly smoke tests on Jenkins for main, its target java 
> version should be bumped to 17.
> In addition to bump the java version, it looks it should be refactored not to 
> hard-code target java version. I feel it'd be better to make it coordinate 
> with the Gradle distribution task.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Reply via email to