[
https://issues.apache.org/jira/browse/LUCENE-10463?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17505211#comment-17505211
]
Tomoko Uchida edited comment on LUCENE-10463 at 3/12/22, 8:25 AM:
------------------------------------------------------------------
My issue description might not good or correct - I didn't mean to integrate the
smoke tester checks into distribution tasks. I understand there could be risks
that obscure the boundary between tests and the tested target. My intention
was, the smoke tester could utilize Gradle to pick common environments or setup
while it is still kept independent from the "distribution" related tasks.
{quote}There are a number of things that rely on the java version,Tomoko - when
Adrien made a bump to Java 17 we kept discovering that "minimum bar" in various
places of the code. Maybe it'd be good to try to cover all of those (or most of
those) under one issue?
{quote}
I still don't get the full picture of all the necessary changes about upgrading
the java version; I will not be able to seek an optimal solution on it.
As for this issue, as an easy fix, we can bump the java version by just
updating all the literal "11" to "17" in the smoke tester script. I think there
would be no harm to make the quick fix so that it works on main.
was (Author: tomoko uchida):
My issue description might not good or correct - I didn't mean to integrate the
smoke tester checks into distribution tasks. I understand there could be risks
that ambiguate the boundary between tests and the tested target. My intention
was, the smoke tester could utilize Gradle to pick common environments or setup
while it is still kept independent from the "distribution" related tasks.
{quote}There are a number of things that rely on the java version,Tomoko - when
Adrien made a bump to Java 17 we kept discovering that "minimum bar" in various
places of the code. Maybe it'd be good to try to cover all of those (or most of
those) under one issue?
{quote}
I still don't get the full picture of all the necessary changes about upgrading
the java version; I will not be able to seek an optimal solution on it.
As for this issue, as an easy fix, we can bump the java version by just
updating all the literal "11" to "17" in the smoke tester script. I think there
would be no harm to make the quick fix so that it works on main.
> Make smoke tester script work on main branch (java 17)
> ------------------------------------------------------
>
> Key: LUCENE-10463
> URL: https://issues.apache.org/jira/browse/LUCENE-10463
> Project: Lucene - Core
> Issue Type: Task
> Reporter: Tomoko Uchida
> Priority: Major
>
> The smoke tester script has been obsoleted on main after upgrading to Java
> 17. To enable nightly smoke tests on Jenkins for main, its target java
> version should be bumped to 17.
> In addition to bump the java version, it looks it should be refactored not to
> hard-code target java version. I feel it'd be better to make it coordinate
> with the Gradle distribution task.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
