uschindler commented on pull request #740: URL: https://github.com/apache/lucene/pull/740#issuecomment-1071008332
I like the idea to remove the code duplication and have only one implementation. On the other hand, if you look at LOC before/after: +1,818 −1,492 We now have 326 lines more, in addition both NORI and Kuromojo hardly depend on code in a different module (analysis-common), which now gets public. So I feel a bit ambiguous about if it really makes sense to forcefully combine those implementations just because we have an overlap of 200 lines. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
