uschindler commented on pull request #740: URL: https://github.com/apache/lucene/pull/740#issuecomment-1072224477
> I think the apparent demerit of this patch is exposing dictionary internals as public interfaces (and kuromoji and nori depend on it). This is also my biggest concern, although the additional complexity and additional interfaces also make me sad. One possibility is to use module system to at least hide the interface for "modern users" (are there any using module system): hide the package :-) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
