mocobeta commented on code in PR #854: URL: https://github.com/apache/lucene/pull/854#discussion_r861437113
########## lucene/CHANGES.txt: ########## @@ -53,7 +53,7 @@ Other * LUCENE-10253: The @BadApple annotation has been removed from the test framework. (Adrien Grand) -* LUCENE-10393: Unify binary dictionary and dictionary writer in Kuromoji and Nori. +* GITHUB-740: Unify binary dictionary and dictionary writer in Kuromoji and Nori. Review Comment: Even if we start to use Github issues in the future, I think this is still valid - CHANGES should directly point PRs, not issues in my opinion. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
