msokolov commented on code in PR #854: URL: https://github.com/apache/lucene/pull/854#discussion_r861995439
########## gradle/documentation/changes-to-html/changes2html.pl: ########## @@ -572,7 +572,7 @@ $item =~ s{((LUCENE|SOLR|INFRA)\s+(\d{3,}))} {<a href="${jira_url_prefix}\U$2\E-$3">$1</a>}gi; # Link "[ github | gh ] pull request [ # ] X+" to Github pull request - $item =~ s{((?:(?:(?:github|gh)\s+)?pull\s+request\s*(?:\#?\s*)?|gh-)(\d+))} + $item =~ s{((?:(?:(?:github|gh)\s+)?pull\s+request\s*(?:\#?\s*)?|gh-|github-)(\d+))} Review Comment: it seems from your examples this is case-insensitive (ie GITHUB works) but I don't see how - the regex has no `i`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org