[GitHub] [lucene] luyuncheng commented on a diff in pull request #987: LUCENE-10627: Using CompositeByteBuf to Reduce Memory Copy

[GitBox]

luyuncheng commented on code in PR #987:
URL: https://github.com/apache/lucene/pull/987#discussion_r920106561


##########
lucene/core/src/java/org/apache/lucene/codecs/compressing/CompressionMode.java:
##########
@@ -257,9 +270,13 @@ private static class DeflateCompressor extends Compressor {
     }
 
     @Override
-    public void compress(byte[] bytes, int off, int len, DataOutput out) 
throws IOException {
+    public void compress(ByteBuffersDataInput buffersInput, int off, int len, 
DataOutput out)

Review Comment:
   > Should we remove `off` and `len` and rely on callers to create a 
`ByteBuffersDataInput#slice` if they only need to compress a subset of the 
input?
   
   at latest 
[commits](https://github.com/luyuncheng/lucene/blob/448e254e1d3c5323f369236492de0d512f537ac2/lucene/core/src/java/org/apache/lucene/codecs/compressing/Compressor.java#L35)
 i only use `  public abstract void compress(ByteBuffersDataInput buffersInput, 
DataOutput out)`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org