luyuncheng commented on PR #987: URL: https://github.com/apache/lucene/pull/987#issuecomment-1183266339
> we prefer to fork the code so that old codecs still rely on the unchanged code (which should move to lucene/backward-codecs) Thanks for the your advice @jpountz , i think it is LGTM. At commit [448e25](https://github.com/luyuncheng/lucene/commit/448e254e1d3c5323f369236492de0d512f537ac2) i try to move old compressor into backward_codecs. And we only use one method `compress(ByteBuffersDataInput buffersInput, DataOutput out)` in Compressor When using ByteBuffersDataInput in compress mehtod, it can 1. Reuse ByteBuffersDataInput reduce memory copy in stored fields compressing 2. Reuse ByteBuffersDataInput reduce memory copy in TermVectors compressing 3. Reuse ByteArrayDataInput reduce memory copy in copyOneDoc -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
