uschindler commented on code in PR #12094: URL: https://github.com/apache/lucene/pull/12094#discussion_r1080678559
########## gradle/java/jar-manifest.gradle: ########## @@ -46,7 +46,9 @@ subprojects { if (snapshotBuild) { return "${project.version} ${gitRev} [snapshot build, details omitted]" } else { - return "${project.version} ${gitRev} - ${System.properties['user.name']} - ${buildDate} ${buildTime}" + def sysProps = System.properties Review Comment: Please don't use system properties directly, with gradle it should be project propreties. Our build system has a method to get project properties which also falls back to sysprops. In short: use `propertyOrDefault('manifest.username', System.properties['user.name'])` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org