uschindler commented on code in PR #12094:
URL: https://github.com/apache/lucene/pull/12094#discussion_r1080678559
##########
gradle/java/jar-manifest.gradle:
##########
@@ -46,7 +46,9 @@ subprojects {
if (snapshotBuild) {
return "${project.version} ${gitRev} [snapshot build, details
omitted]"
} else {
- return "${project.version} ${gitRev} -
${System.properties['user.name']} - ${buildDate} ${buildTime}"
+ def sysProps = System.properties
Review Comment:
Please don't use system properties directly for build properties; with
gradle it should be project properties. Our build system has a method to get
project properties which also falls back to sysprops. In short: use
`propertyOrDefault('manifest.username', System.properties['user.name'])`
"user.name" is a real system property, so it is correct to use it here
(otherwise you could fake it). But the project property should be given by
gradle. This also allows to set it in your local gradle.properties.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
