jpountz commented on PR #12194: URL: https://github.com/apache/lucene/pull/12194#issuecomment-1475781767
> As Lucene does a lot of two phase iterations, and two phase iterator's approximation may provide a superset of the actual matches. If we were to use this API to find and ignore / skip over a bunch of doc ids from approximation, wouldn't the result be inaccurate? Indeed we need to be careful wrt how this new API is used with two-phase iterators. The code path that you shared should only be enabled when there is no two-phase confirmation? It will force linear evaluation of matches with two-phase iterators, but I think it's fine, these tend to be slow anyway. > I feel the result so far looks promising. Very cool indeed! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
