jpountz commented on PR #12194:
URL: https://github.com/apache/lucene/pull/12194#issuecomment-1475794788
I have some suggestions for moving this PR forward:
- Enhance CheckIndex to check that peekNextNonMatcthingDocID is correct.
- Enhance AssertingScorer to check that peekNextNonMatchingDocID is only
called when the iterator is positioned. Also check return values.
- Revert changes to bitsets and doc-value iterators, let's only focus on
postings and negations to keep this initial PR simple? We'll add support for
bitsets and doc-value iterators in follow-ups? Maybe we could consider
conjunctions too for this initial PR, which are far more common than negations
in my experience.
- See if we can leverage skip data to skip over longer ranges of doc IDs
with postings.
- See if we can reduce the slowdown on `OrNotHighHigh` and other negations
when the optimization does not kick in.
- A `quarter` field is a bit extreme, see if we can also observe good
speedups with something less extreme like the `month` field?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
