ChrisHegarty commented on PR #12311:
URL: https://github.com/apache/lucene/pull/12311#issuecomment-1554440332
I refactored the provider and impl's:
1. So as to separate them out from VectorUtil - this should improve
readability, etc, as we move beyond dotProduct.
2. I also moved them into a it's own non-exported package.
I'm less sure about no.2. The general thought was that the code might be
more reusable from there, but now that I think about it, it might be better as
package-private where it was, since the "interface" is through VectorUtils -
not directly to the imp. Thoughts?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
