javanna commented on code in PR #12369:
URL: https://github.com/apache/lucene/pull/12369#discussion_r1229356704
##########
lucene/test-framework/src/java/org/apache/lucene/tests/util/LuceneTestCase.java:
##########
@@ -1965,9 +1966,9 @@ public static IndexSearcher newSearcher(
.addClosedListener(cacheKey ->
TestUtil.shutdownExecutorService(ex));
}
IndexSearcher ret;
+ int maxDocPerSlice = random.nextBoolean() ? 1 : 1 + random.nextInt(1000);
+ int maxSegmentsPerSlice = random.nextBoolean() ? 1 : 1 +
random.nextInt(10);
Review Comment:
This may be too aggressive, as we may end up with way too many slices
depending on how many docs and segments tests have. An alternative would be to
have a different value distribution that is closer to the lower bound of the
range. Another option could be to make this configurable so that tests that
want a behaviour that is closed to production can override it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
