javanna commented on code in PR #12369:
URL: https://github.com/apache/lucene/pull/12369#discussion_r1229508836
##########
lucene/test-framework/src/java/org/apache/lucene/tests/util/LuceneTestCase.java:
##########
@@ -1941,7 +1940,7 @@ public static IndexSearcher newSearcher(
} else {
int threads = 0;
final ThreadPoolExecutor ex;
- if (r.getReaderCacheHelper() == null || random.nextBoolean()) {
+ if (r.getReaderCacheHelper() == null || rarely()) {
Review Comment:
I see, maybe it's too many changes at the same time. Not setting the
executor half of the times though lowers the likelihood quite a bit, which is
lowered further by the slices thresholds. I agree that we should not guarantee
that we always parallelize when we may use threads, yet I am trying to have
that happen at least 50% of the times, instead of a couple of times every 1000
runs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
