vsop-479 commented on PR #11888:
URL: https://github.com/apache/lucene/pull/11888#issuecomment-1999256752
@jpountz
I want to move `subCheckBinarySearch` to `BasePostingsFormatTestCase` to
make this change forward compatible, by judging whether `IndexWriterConfig` is
set DefaultPostingsFormat like this:
````
if (TestUtil.getDefaultPostingsFormat()
.getName()
.equals(TestUtil.getPostingsFormat(iwc.getCodec(), "id"))) {
// test target greater than the last entry of matched block,
}
````
But it won't pass if this DefaultPostingsFormat do not use
`DEFAULT_MIN_BLOCK_SIZE` and `DEFAULT_MAX_BLOCK_SIZE`, such as
`TestPerFieldPostingsFormat`.
I also tried to set DefaultCodec to test target greater than the last entry
of matched block case, like this:
````
iwc.setCodec(TestUtil.getDefaultCodec());
````
`TestSTUniformSplitPostingFormat.checkEncoding` won't pass this, because it
must use its own `FieldsConsumer` to set states like `blocksEncoded`.
Do you have any idea about this?
Can we expose `minTermBlockSize` and `maxTermBlockSize` in
`LuceneXXPostingsFormat` to a `DefaultPostingsFormat`, to let user use them?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
