vsop-479 commented on PR #11888:
URL: https://github.com/apache/lucene/pull/11888#issuecomment-2022219035

   @mikemccand Thanks for your review.
   I measured performance on `wikimediumall`:
   
   # iter1
   ````
   TaskQPS baseline      StdDevQPS my_modified_version      StdDev              
  Pct diff p-value
              BrowseMonthTaxoFacets       11.02     (26.9%)       10.62     
(28.4%)   -3.7% ( -46% -   70%) 0.727
        BrowseRandomLabelSSDVFacets        6.22      (9.1%)        6.04      
(6.5%)   -2.9% ( -16% -   13%) 0.335
                  HighTermTitleSort      184.11      (4.0%)      180.43      
(4.0%)   -2.0% (  -9% -    6%) 0.187
                         TermDTSort      214.19      (4.6%)      210.41      
(4.2%)   -1.8% ( -10% -    7%) 0.290
                  HighTermMonthSort     4049.75      (3.8%)     4009.22      
(6.2%)   -1.0% ( -10% -    9%) 0.606
             OrHighMedDayTaxoFacets        6.41      (6.7%)        6.35      
(7.5%)   -0.9% ( -14% -   14%) 0.737
                            Prefix3      562.57      (1.3%)      558.72      
(1.7%)   -0.7% (  -3% -    2%) 0.228
           AndHighHighDayTaxoFacets       23.16      (1.5%)       23.02      
(1.6%)   -0.6% (  -3% -    2%) 0.288
                         HighPhrase       49.14      (3.9%)       48.88      
(3.1%)   -0.5% (  -7% -    6%) 0.698
               MedTermDayTaxoFacets       17.63      (3.6%)       17.55      
(2.9%)   -0.4% (  -6% -    6%) 0.718
                       HighSpanNear       15.30      (1.8%)       15.24      
(1.5%)   -0.4% (  -3% -    3%) 0.544
               HighTermTitleBDVSort       10.23      (2.4%)       10.19      
(3.0%)   -0.4% (  -5% -    5%) 0.717
          BrowseDayOfYearSSDVFacets        6.97      (6.3%)        6.95      
(6.0%)   -0.3% ( -11% -   12%) 0.890
                            Respell       73.65      (1.5%)       73.44      
(2.4%)   -0.3% (  -4% -    3%) 0.717
              HighTermDayOfYearSort      525.93      (2.5%)      524.54      
(3.0%)   -0.3% (  -5% -    5%) 0.799
                        MedSpanNear       75.25      (2.6%)       75.16      
(1.5%)   -0.1% (  -4% -    3%) 0.882
                          MedPhrase       62.74      (4.7%)       62.73      
(2.6%)   -0.0% (  -6% -    7%) 0.987
                        LowSpanNear       10.39      (2.1%)       10.39      
(1.4%)    0.0% (  -3% -    3%) 0.998
                             Fuzzy1       99.01      (1.7%)       99.07      
(1.6%)    0.1% (  -3% -    3%) 0.923
                      OrNotHighHigh      576.76      (4.0%)      578.77      
(4.5%)    0.3% (  -7% -    9%) 0.827
            AndHighMedDayTaxoFacets       80.00      (1.3%)       80.29      
(1.6%)    0.4% (  -2% -    3%) 0.511
                          LowPhrase      149.97      (2.9%)      150.57      
(2.1%)    0.4% (  -4% -    5%) 0.675
                          OrHighLow      675.00      (2.6%)      678.06      
(3.1%)    0.5% (  -5% -    6%) 0.674
               HighIntervalsOrdered        2.81     (14.0%)        2.83     
(11.6%)    0.5% ( -22% -   30%) 0.921
                         AndHighLow     1027.38      (4.2%)     1032.64      
(3.9%)    0.5% (  -7% -    8%) 0.738
                           Wildcard      100.84      (2.4%)      101.44      
(2.8%)    0.6% (  -4% -    5%) 0.547
                             Fuzzy2       92.33      (1.5%)       92.98      
(1.4%)    0.7% (  -2% -    3%) 0.206
                MedIntervalsOrdered       13.07     (10.5%)       13.18      
(9.4%)    0.8% ( -17% -   23%) 0.824
              BrowseMonthSSDVFacets        6.91      (8.0%)        6.97      
(7.1%)    0.9% ( -13% -   17%) 0.748
                       OrNotHighMed      341.39      (3.4%)      345.26      
(3.2%)    1.1% (  -5% -    7%) 0.362
                         AndHighMed      155.80      (3.0%)      157.63      
(3.2%)    1.2% (  -4% -    7%) 0.316
          BrowseDayOfYearTaxoFacets        7.70      (4.0%)        7.79      
(4.4%)    1.2% (  -6% -    9%) 0.450
                         OrHighHigh       42.26      (3.9%)       42.77      
(3.6%)    1.2% (  -6% -    9%) 0.396
        BrowseRandomLabelTaxoFacets        7.17      (5.0%)        7.26      
(4.5%)    1.2% (  -7% -   11%) 0.486
                      OrHighNotHigh      464.54      (4.5%)      470.46      
(5.2%)    1.3% (  -8% -   11%) 0.490
                            LowTerm      669.77      (3.4%)      678.39      
(4.3%)    1.3% (  -6% -    9%) 0.383
                          OrHighMed      118.91      (3.2%)      120.47      
(3.1%)    1.3% (  -4% -    7%) 0.270
                LowIntervalsOrdered       63.73      (8.3%)       64.58      
(7.7%)    1.3% ( -13% -   18%) 0.657
               BrowseDateTaxoFacets        7.63      (3.8%)        7.74      
(3.8%)    1.4% (  -5% -    9%) 0.324
                        AndHighHigh       30.16      (5.2%)       30.61      
(2.2%)    1.5% (  -5% -    9%) 0.323
                       OrNotHighLow     1186.21      (4.7%)     1203.99      
(3.2%)    1.5% (  -6% -    9%) 0.326
                    LowSloppyPhrase        7.71      (2.4%)        7.82      
(1.8%)    1.5% (  -2% -    5%) 0.058
                       OrHighNotLow      723.44      (4.9%)      734.39      
(5.1%)    1.5% (  -8% -   12%) 0.425
                    MedSloppyPhrase       49.22      (2.7%)       49.99      
(2.0%)    1.6% (  -3% -    6%) 0.081
                           HighTerm      605.77      (5.9%)      617.81      
(8.3%)    2.0% ( -11% -   17%) 0.466
                            MedTerm      554.77      (3.9%)      565.82      
(4.9%)    2.0% (  -6% -   11%) 0.234
                       OrHighNotMed      594.17      (4.4%)      606.01      
(6.0%)    2.0% (  -8% -   12%) 0.314
                   HighSloppyPhrase       10.92      (3.0%)       11.18      
(4.1%)    2.4% (  -4% -    9%) 0.076
               BrowseDateSSDVFacets        1.59     (16.7%)        1.67     
(12.7%)    4.8% ( -21% -   41%) 0.391
                           PKLookup      294.05      (2.2%)      312.97      
(2.7%)    6.4% (   1% -   11%) 0.000
                             IntNRQ       28.82     (12.4%)       31.23      
(8.1%)    8.4% ( -10% -   32%) 0.034
   ````
   
   # iter2
   ````
   TaskQPS baseline      StdDevQPS my_modified_version      StdDev              
  Pct diff p-value
              BrowseMonthTaxoFacets       11.45     (27.9%)       11.02     
(28.4%)   -3.8% ( -46% -   72%) 0.678
        BrowseRandomLabelSSDVFacets        6.33      (9.5%)        6.20      
(8.4%)   -2.1% ( -18% -   17%) 0.468
                  HighTermTitleSort      185.35      (4.0%)      182.85      
(4.4%)   -1.3% (  -9% -    7%) 0.322
                  HighTermMonthSort     4091.54      (4.2%)     4049.63      
(5.8%)   -1.0% ( -10% -    9%) 0.531
               HighTermTitleBDVSort       10.47      (7.8%)       10.37      
(8.2%)   -1.0% ( -15% -   16%) 0.708
                         HighPhrase       48.93      (3.8%)       48.56      
(3.2%)   -0.8% (  -7% -    6%) 0.501
               MedTermDayTaxoFacets       17.68      (3.7%)       17.55      
(2.6%)   -0.7% (  -6% -    5%) 0.491
                          MedPhrase       62.41      (4.5%)       62.00      
(3.3%)   -0.7% (  -8% -    7%) 0.610
                            Prefix3      561.61      (1.5%)      558.87      
(1.8%)   -0.5% (  -3% -    2%) 0.353
          BrowseDayOfYearSSDVFacets        6.92      (5.8%)        6.89      
(5.6%)   -0.4% ( -11% -   11%) 0.812
           AndHighHighDayTaxoFacets       23.15      (1.3%)       23.05      
(1.6%)   -0.4% (  -3% -    2%) 0.379
               HighIntervalsOrdered        2.88     (13.5%)        2.87     
(11.3%)   -0.4% ( -22% -   28%) 0.920
                            Respell       73.56      (1.7%)       73.43      
(2.3%)   -0.2% (  -4% -    3%) 0.786
                       HighSpanNear       15.27      (2.1%)       15.24      
(1.6%)   -0.1% (  -3% -    3%) 0.815
             OrHighMedDayTaxoFacets        6.38      (6.7%)        6.37      
(7.1%)   -0.1% ( -13% -   14%) 0.962
                          LowPhrase      149.81      (2.6%)      149.67      
(2.2%)   -0.1% (  -4% -    4%) 0.906
                      OrNotHighHigh      580.27      (3.8%)      579.77      
(4.1%)   -0.1% (  -7% -    8%) 0.946
                             Fuzzy1       98.99      (1.7%)       98.93      
(1.9%)   -0.1% (  -3% -    3%) 0.909
                         TermDTSort      213.72      (4.9%)      213.68      
(4.5%)   -0.0% (  -9% -    9%) 0.989
                           Wildcard      100.49      (2.9%)      100.53      
(3.2%)    0.0% (  -5% -    6%) 0.962
                         AndHighLow     1032.43      (4.0%)     1033.17      
(3.8%)    0.1% (  -7% -    8%) 0.955
                MedIntervalsOrdered       13.27     (10.0%)       13.29      
(8.9%)    0.1% ( -17% -   21%) 0.976
                        LowSpanNear       10.39      (2.1%)       10.41      
(1.3%)    0.2% (  -3% -    3%) 0.776
                        MedSpanNear       75.09      (2.6%)       75.24      
(1.4%)    0.2% (  -3% -    4%) 0.773
                          OrHighLow      678.64      (2.6%)      680.45      
(3.1%)    0.3% (  -5% -    6%) 0.774
              HighTermDayOfYearSort      526.84      (2.5%)      528.27      
(3.1%)    0.3% (  -5% -    6%) 0.769
            AndHighMedDayTaxoFacets       80.31      (1.5%)       80.54      
(1.5%)    0.3% (  -2% -    3%) 0.554
                         AndHighMed      156.61      (2.8%)      157.25      
(3.2%)    0.4% (  -5% -    6%) 0.679
                             Fuzzy2       92.44      (1.8%)       92.87      
(1.7%)    0.5% (  -2% -    3%) 0.414
              BrowseMonthSSDVFacets        6.86      (7.1%)        6.90      
(6.6%)    0.5% ( -12% -   15%) 0.810
                      OrHighNotHigh      469.04      (4.6%)      471.62      
(5.0%)    0.5% (  -8% -   10%) 0.725
                       OrNotHighMed      342.44      (3.5%)      344.34      
(3.1%)    0.6% (  -5% -    7%) 0.604
                       OrNotHighLow     1198.89      (4.9%)     1205.92      
(3.8%)    0.6% (  -7% -    9%) 0.678
                          OrHighMed      119.89      (3.2%)      120.59      
(2.8%)    0.6% (  -5% -    6%) 0.544
                            LowTerm      676.75      (3.8%)      680.77      
(3.9%)    0.6% (  -6% -    8%) 0.637
                         OrHighHigh       42.52      (3.5%)       42.81      
(3.2%)    0.7% (  -5% -    7%) 0.542
                LowIntervalsOrdered       64.52      (8.0%)       64.98      
(7.2%)    0.7% ( -13% -   17%) 0.777
          BrowseDayOfYearTaxoFacets        7.77      (4.2%)        7.83      
(4.5%)    0.8% (  -7% -    9%) 0.592
        BrowseRandomLabelTaxoFacets        7.26      (4.8%)        7.32      
(4.2%)    0.8% (  -7% -   10%) 0.589
               BrowseDateTaxoFacets        7.70      (3.9%)        7.77      
(3.9%)    0.8% (  -6% -    9%) 0.505
                        AndHighHigh       30.28      (4.6%)       30.56      
(2.4%)    0.9% (  -5% -    8%) 0.443
                           HighTerm      613.47      (5.8%)      619.30      
(7.4%)    0.9% ( -11% -   14%) 0.659
                       OrHighNotLow      732.44      (5.1%)      739.78      
(5.2%)    1.0% (  -8% -   11%) 0.548
                    MedSloppyPhrase       49.44      (2.7%)       49.97      
(2.0%)    1.1% (  -3% -    5%) 0.167
                    LowSloppyPhrase        7.74      (2.5%)        7.83      
(2.0%)    1.1% (  -3% -    5%) 0.118
                            MedTerm      560.71      (3.8%)      567.47      
(4.6%)    1.2% (  -6% -    9%) 0.378
                       OrHighNotMed      599.96      (4.3%)      607.78      
(5.3%)    1.3% (  -7% -   11%) 0.404
                   HighSloppyPhrase       11.05      (4.0%)       11.22      
(3.8%)    1.5% (  -6% -    9%) 0.232
               BrowseDateSSDVFacets        1.58     (16.2%)        1.64     
(13.1%)    3.6% ( -22% -   39%) 0.448
                             IntNRQ       29.55     (11.8%)       31.30      
(7.8%)    5.9% ( -12% -   28%) 0.066
                           PKLookup      294.20      (2.3%)      312.60      
(2.5%)    6.3% (   1% -   11%) 0.000
   ````
   
   # iter3
   ````
   TaskQPS baseline      StdDevQPS my_modified_version      StdDev              
  Pct diff p-value
        BrowseRandomLabelSSDVFacets        6.32      (9.3%)        6.20      
(8.2%)   -1.9% ( -17% -   17%) 0.501
                  HighTermTitleSort      185.14      (3.9%)      182.87      
(4.3%)   -1.2% (  -9% -    7%) 0.344
                         HighPhrase       48.99      (3.8%)       48.56      
(3.1%)   -0.9% (  -7% -    6%) 0.409
                  HighTermMonthSort     4102.48      (4.2%)     4067.36      
(5.9%)   -0.9% ( -10% -    9%) 0.599
                          MedPhrase       62.50      (4.4%)       62.01      
(3.2%)   -0.8% (  -8% -    7%) 0.520
               HighTermTitleBDVSort       10.44      (7.7%)       10.36      
(8.0%)   -0.8% ( -15% -   16%) 0.759
               MedTermDayTaxoFacets       17.64      (3.7%)       17.53      
(2.6%)   -0.6% (  -6% -    5%) 0.543
              BrowseMonthTaxoFacets       11.18     (29.8%)       11.11     
(28.6%)   -0.6% ( -45% -   82%) 0.947
                            Prefix3      561.39      (1.4%)      559.08      
(1.7%)   -0.4% (  -3% -    2%) 0.411
               HighIntervalsOrdered        2.89     (13.3%)        2.88     
(11.1%)   -0.4% ( -21% -   27%) 0.921
           AndHighHighDayTaxoFacets       23.11      (1.4%)       23.04      
(1.6%)   -0.3% (  -3% -    2%) 0.492
          BrowseDayOfYearSSDVFacets        6.92      (5.6%)        6.90      
(5.5%)   -0.2% ( -10% -   11%) 0.889
                         AndHighLow     1037.33      (4.4%)     1036.39      
(3.9%)   -0.1% (  -8% -    8%) 0.945
                          LowPhrase      150.03      (2.6%)      149.91      
(2.3%)   -0.1% (  -4% -    4%) 0.920
                            Respell       73.55      (1.7%)       73.51      
(2.3%)   -0.1% (  -3% -    3%) 0.932
                       HighSpanNear       15.25      (2.1%)       15.24      
(1.6%)   -0.0% (  -3% -    3%) 0.942
                      OrNotHighHigh      581.80      (3.9%)      581.70      
(4.2%)   -0.0% (  -7% -    8%) 0.989
                MedIntervalsOrdered       13.30      (9.8%)       13.31      
(8.7%)    0.0% ( -16% -   20%) 0.995
              HighTermDayOfYearSort      528.23      (2.7%)      528.68      
(3.1%)    0.1% (  -5% -    6%) 0.926
                             Fuzzy1       98.95      (1.7%)       99.06      
(1.9%)    0.1% (  -3% -    3%) 0.843
                           Wildcard      100.55      (2.8%)      100.69      
(3.2%)    0.1% (  -5% -    6%) 0.889
             OrHighMedDayTaxoFacets        6.38      (6.5%)        6.39      
(7.0%)    0.2% ( -12% -   14%) 0.943
                        LowSpanNear       10.39      (2.0%)       10.41      
(1.3%)    0.2% (  -2% -    3%) 0.693
                         TermDTSort      213.54      (4.8%)      214.09      
(4.5%)    0.3% (  -8% -   10%) 0.861
                        MedSpanNear       75.05      (2.6%)       75.26      
(1.3%)    0.3% (  -3% -    4%) 0.670
                          OrHighMed      120.32      (3.5%)      120.68      
(2.7%)    0.3% (  -5% -    6%) 0.762
            AndHighMedDayTaxoFacets       80.24      (1.5%)       80.49      
(1.5%)    0.3% (  -2% -    3%) 0.505
                          OrHighLow      680.40      (2.8%)      683.00      
(3.4%)    0.4% (  -5% -    6%) 0.698
                         OrHighHigh       42.66      (3.7%)       42.86      
(3.2%)    0.5% (  -6% -    7%) 0.675
                             Fuzzy2       92.47      (1.7%)       92.96      
(1.7%)    0.5% (  -2% -    4%) 0.327
                         AndHighMed      157.18      (3.2%)      158.05      
(3.8%)    0.6% (  -6% -    7%) 0.622
                LowIntervalsOrdered       64.61      (7.8%)       65.02      
(7.0%)    0.6% ( -13% -   16%) 0.789
                       OrHighNotLow      735.60      (5.3%)      740.40      
(5.0%)    0.7% (  -9% -   11%) 0.690
                      OrHighNotHigh      469.07      (4.5%)      472.19      
(4.9%)    0.7% (  -8% -   10%) 0.654
              BrowseMonthSSDVFacets        6.86      (7.0%)        6.90      
(6.5%)    0.7% ( -11% -   15%) 0.745
                       OrNotHighMed      342.82      (3.4%)      345.24      
(3.2%)    0.7% (  -5% -    7%) 0.503
                            LowTerm      677.45      (3.8%)      682.23      
(3.9%)    0.7% (  -6% -    8%) 0.562
                           HighTerm      615.74      (5.8%)      621.00      
(7.3%)    0.9% ( -11% -   14%) 0.682
        BrowseRandomLabelTaxoFacets        7.27      (4.7%)        7.34      
(4.2%)    0.9% (  -7% -   10%) 0.514
                        AndHighHigh       30.34      (4.5%)       30.63      
(2.6%)    0.9% (  -5% -    8%) 0.418
                       OrNotHighLow     1199.25      (4.8%)     1211.93      
(4.3%)    1.1% (  -7% -   10%) 0.460
                    MedSloppyPhrase       49.50      (2.7%)       50.05      
(2.0%)    1.1% (  -3% -    6%) 0.143
                    LowSloppyPhrase        7.76      (2.5%)        7.84      
(2.1%)    1.1% (  -3% -    5%) 0.113
                       OrHighNotMed      602.01      (4.5%)      609.14      
(5.2%)    1.2% (  -8% -   11%) 0.439
          BrowseDayOfYearTaxoFacets        7.75      (4.2%)        7.84      
(4.4%)    1.2% (  -7% -   10%) 0.384
               BrowseDateTaxoFacets        7.69      (3.9%)        7.78      
(3.9%)    1.2% (  -6% -    9%) 0.319
                            MedTerm      560.55      (3.7%)      567.87      
(4.5%)    1.3% (  -6% -    9%) 0.315
                   HighSloppyPhrase       11.04      (4.0%)       11.21      
(3.7%)    1.6% (  -5% -    9%) 0.189
               BrowseDateSSDVFacets        1.60     (16.1%)        1.67     
(14.3%)    4.2% ( -22% -   41%) 0.386
                             IntNRQ       29.63     (11.5%)       31.30      
(7.5%)    5.6% ( -12% -   27%) 0.067
                           PKLookup      293.94      (2.2%)      312.15      
(2.6%)    6.2% (   1% -   11%) 0.000
   ````


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Reply via email to