rmuir commented on issue #13706:
URL: https://github.com/apache/lucene/issues/13706#issuecomment-2324907262
> I had a similar thought. Looking at the code it kinda looks a little
tacky, but also kinda makes sone sense, e.g.
>
> ```diff
> case REGEXP_REPEAT:
> + if (exp1.kind == Kind.REGEXP_ANYCHAR && automaton_provider ==
null) {
> + return Automata.makeAnyString();
> + } else {
> a = Operations.repeat(exp1.toAutomaton(automata,
automaton_provider));
> + }
> break;
> ```
let's fix the regexp parser first? It is easier to reason about and less
scary than stuff like `isTotal` and `subsetOf`.
Previously, regexp parser was calling `minimize()` on
every...parsing...step. I removed this because it is obviously not good. But if
we have a simple fix to make it emit better automaton for practical uses, let's
do it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
