rmuir commented on issue #13706: URL: https://github.com/apache/lucene/issues/13706#issuecomment-2324948858
> @rmuir Just skimming your update to isTotal, it looks good. I think that it will be more generally useful, given that we minimize less now. need to stare at it some more. I don't like that it uses some stuff such as `sameLanguage` which has a TODO to move to tests/test-framework and is currently only used by tests. And since we are checking for "total", we definitely don't need to do subsetOf twice: `subsetOf(a2, a1) && subsetOf(a1, a2)`. and I don't like that `subsetOf` is quadratic to the number of states: it is heavy stuff. There is probably a simpler algorithm. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
