rmuir opened a new pull request, #13708: URL: https://github.com/apache/lucene/pull/13708
These methods run in quadratic time and have been traps in the past: they run in quadratic time. I think originally this was `equals()` but it is so costly, that we factored out into separate `sameLanguage` methods. Additionally methods are a bit smelly, they will throw exception if the inputs aren't deterministic, and they'll only `assert` if there are transitions to dead states... they are really only suitable for tests code. We've been making progress moving some of this code to test framework, this is just the next iteration. Would love to factor out more (dead states checks etc) but that's more difficult. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
