rmuir opened a new pull request, #13707: URL: https://github.com/apache/lucene/pull/13707
Operations.isTotal currently returns `false` unless the DFA is minimal. This makes the method almost useless and we definitely don't want to encourage minimization just to make such a check. Can we do a better job, e.g. return `true` for a non-minimal DFA? There's an example test added that fails without the change to demonstrate: ``` // deterministic, but not minimal assertTrue(Operations.isTotal(Operations.repeat(Automata.makeAnyChar()))); ``` This is a draft PR because I still don't like that it uses `subsetOf`, the code literally makes a minimal "total DFA" and compares that the two automata recognize the same language. Because it is total, we only need to call subsetOf once, but I still don't like how heavy it is. Can we do better? See #13706 for more background -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
