rmuir commented on issue #13706:
URL: https://github.com/apache/lucene/issues/13706#issuecomment-2329167160

   > Is `subsetOf` really quadratic? I know its javadoc says so, but I'm not 
convinced.
   
   I think this is only one of the scarier parts about it. The other scary part 
is that it may throw `IllegalArgumentException`, or in some cases 
`AssertionError` (if asserts are enabled, if not... UB?). 
   
   For these reasons too, I wanted to avoid its usage in something that gets 
called e.g. by CompiledAutomaton and proposed moving it to AutomatonTestUtil 
for test purposes only: https://github.com/apache/lucene/pull/13708


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Reply via email to