gsmiller commented on issue #13725: URL: https://github.com/apache/lucene/issues/13725#issuecomment-2332818574
My vote would be to be more restrictive with these signatures and specify `FacetsCollectorManager` given that these are sugar methods meant to make it easier to do faceting while also the "main" search. Today's faceting module all works against `FacetsCollector` explicitly in the various APIs, so having a generic `Collector` or `CollectorManager` here seems confusing IMO. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
