javanna commented on issue #13725: URL: https://github.com/apache/lucene/issues/13725#issuecomment-2333752360
I agree @gsmiller , I am inclined to be stricter. Also, while we make this breaking change, we can go directly from `Collector` to `FacetsCollectorManager`. I am also considering moving these static methods to `FacetsCollectorManager`. It feels weird to have them exposed to `FacetsCollector` but require the corresponding manager. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
