javanna commented on PR #13777: URL: https://github.com/apache/lucene/pull/13777#issuecomment-2346813650
I am not getting many test failures, which is surprising, because I think that this is entirely the wrong fix, in that it defeats the early termination purpose of top score docs collector. I don't have good ideas on how to fix this properly so far, without API changes, in that leaf collector don't have a way to get notified that the current segment is seen as part of a segment partition. It would be enough to get the min doc id of the partition, and use it as doc base in the accumulator, but it's hard to get it there with the current API. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
