javanna commented on code in PR #13777:
URL: https://github.com/apache/lucene/pull/13777#discussion_r1757494555
##########
lucene/core/src/java/org/apache/lucene/search/TopScoreDocCollector.java:
##########
@@ -232,7 +232,7 @@ protected void updateGlobalMinCompetitiveScore(Scorable
scorer) throws IOExcepti
// the next float if the global minimum score is set on a document id
that is
// smaller than the ids in the current leaf
float score =
- docBase >= maxMinScore.docBase() ? Math.nextUp(maxMinScore.score())
: maxMinScore.score();
+ docBase >= maxMinScore.docId() ? Math.nextUp(maxMinScore.score()) :
maxMinScore.score();
Review Comment:
I see what you mean , I gave it a try, but then I reverted it, I prefer to
think about testing and do it as a follow-up
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
