rmuir commented on code in PR #14933:
URL: https://github.com/apache/lucene/pull/14933#discussion_r2202685407
##########
gradle/regenerate/snowball/snowball.sh:
##########
@@ -47,7 +47,7 @@ for file in ${SRCDIR}/java/org/tartarus/snowball/ext/*.java;
do
# title-case the classes (fooStemmer -> FooStemmer) so they obey normal java
conventions
base=$(basename $file)
oldclazz="${base%.*}"
- newclazz=${oldclazz^}
+ newclazz=$(echo "$oldclazz" | perl -pe 's/^(.)/\U$1/')
Review Comment:
long-term i think the best fix would be to submit snowball a patch to
address the naming to remove the hack: they were welcoming of such improvements
the last time I tried to work some of these hacks off.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
