dweiss commented on code in PR #14933:
URL: https://github.com/apache/lucene/pull/14933#discussion_r2202485613
##########
build-tools/build-infra/src/main/groovy/lucene.regenerate.gradle:
##########
@@ -135,14 +195,17 @@ configure([
// ignoreWithSource: any other tasks that should be ignored if the
internal task is ignored
// (checksums are identical)
// mustRunBefore: any tasks which should be scheduled to run after the
internal task.
- wrapWithPersistentChecksums = { Task sourceTask, Map<String, Object>
extraConfig = [:] ->
+ wrapWithPersistentChecksums2 = {TaskProvider sourceTaskProvider,
Map<String, Object> extraConfig = [:] ->
+ wrapWithPersistentChecksums(sourceTaskProvider.get(), extraConfig)
+ }
+ wrapWithPersistentChecksums = {Task sourceTask, Map<String, Object>
extraConfig = [:] ->
Review Comment:
This is something I'm leaving for later - it currently instantiates the task
but there is no simple way around it.
##########
gradle/regenerate/snowball/snowball.sh:
##########
@@ -47,7 +47,7 @@ for file in ${SRCDIR}/java/org/tartarus/snowball/ext/*.java;
do
# title-case the classes (fooStemmer -> FooStemmer) so they obey normal java
conventions
base=$(basename $file)
oldclazz="${base%.*}"
- newclazz=${oldclazz^}
+ newclazz=$(echo "$oldclazz" | perl -pe 's/^(.)/\U$1/')
Review Comment:
this hack is needed for macos because it has an old bash by default and
doesn't support the fancy uppercasing syntax. Hope it's not a problem.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
