rmuir commented on code in PR #14933:
URL: https://github.com/apache/lucene/pull/14933#discussion_r2202687658
##########
gradle/regenerate/snowball/snowball.sh:
##########
@@ -47,7 +47,7 @@ for file in ${SRCDIR}/java/org/tartarus/snowball/ext/*.java;
do
# title-case the classes (fooStemmer -> FooStemmer) so they obey normal java
conventions
base=$(basename $file)
oldclazz="${base%.*}"
- newclazz=${oldclazz^}
+ newclazz=$(echo "$oldclazz" | perl -pe 's/^(.)/\U$1/')
Review Comment:
we could also try to stop doing this, and add exceptions to any checkers
around the naming in use.
I think I previously explored that option, but java tools were extremely
angry about class named `fooStemmer`... they complained louder than you would
imagine.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
