romseygeek commented on PR #15469: URL: https://github.com/apache/lucene/pull/15469#issuecomment-3738098531
We've seen some CI failures after this merged - reproduce with ```./gradlew :lucene:core:test --tests "org.apache.lucene.index.TestFilterLeafReader.testFilterIndexReader" -Ptests.asserts=true -Ptests.file.encoding=UTF-8 -Ptests.gui=true -Ptests.jvmargs= -Ptests.jvms=12 -Ptests.seed=CE6E3124C37548F0 -Ptests.vectorsize=default``` The root of the problem is `DocIdSetIterator.intoBitSet()`, which is very closely tied to `nextDoc()` behaviour. If you override `nextDoc()` but not `intoBitSet()`, and the delegate behaviour doesn't use the default implementation, then you may get incorrect behaviour. This wasn't a problem before because `intoBitSet()` wasn't delegated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
