john-wagster commented on PR #15753: URL: https://github.com/apache/lucene/pull/15753#issuecomment-3946230301
> I don't think we should add boolean parameters to the existing functions, we should add separate functions. This suggestion sounds good to me. @rmuir I updated the functions to no longer take boolean parameters and instead introduced separately named `makeCaseInsensitiveChar` and `makeCaseInsensitiveString` let me know if that's out of line with what you were hoping. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
